Added retrieval of sections #10851
Added retrieval of sections #10851
Conversation
umpirsky
commented
May 3, 2014
umpirsky
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10145 |
| License | MIT |
There was a problem hiding this comment.
I think in this case Section class should be extracted into the separate file. Also @internal phpDoc should be removed from this class annotation.
There was a problem hiding this comment.
Yes, I agree. Will do.
|
Done. |
|
Any reason not to merge this? |
|
@umpirsky yes. 2.5 reached its feature freeze 1.5 month ago so no new features are merged in it anymore. and merging 2.6 PRs has not started yet |
|
@stof So basically this PR just waits for 2.6? |
|
Thank you @umpirsky. |
There was a problem hiding this comment.
Missing phpDoc here, at least the return type
There was a problem hiding this comment.
There is phpdoc on the class attribute so return type can be figured out by any IDE if that is the point.
There was a problem hiding this comment.
Ok, I was just wondering if it is consistent with the actual code base?
There was a problem hiding this comment.
There is no general rule. I am not big fan of phpdocs, unless you have something really useful to say in them. 😄
There was a problem hiding this comment.
but here, you have something to say: @return Section[] to document the return type
There was a problem hiding this comment.
no it is not. Your IDE cannot guess that the return value is an array of Section objects when providing completion (well, some IDE could because we have phpdoc on the private property here, but we generally prefer documenting public stuff). The API doc builder cannot guess it either.
And someone not reading the full code may not guess it either.
…) (umpirsky) This PR was merged into the 2.6-dev branch. Discussion ---------- [Stopwatch] Added return type to Stopwatch::getSections() #10851 (comment) Commits ------- ab00361 Added return type to Stopwatch::getSections()
