[WIP][Form] Improve transformation failure message by providing property path #11318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jubianchi
commented
Jul 5, 2014
jubianchi
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | |
| Fixed tickets | #11287 |
| License | MIT |
| Doc PR |
| @@ -37,7 +37,7 @@ public function reverseTransform($value) | |||
| $result = array_search($value, $this->mapping, true); | |||
|
|
|||
| if ($result === false) { | |||
| throw new RuntimeException(sprintf('No reverse mapping for value "%s"', $value)); | |||
| throw new TransformationFailedException(sprintf('No reverse mapping for value "%s"', $value)); | |||
There was a problem hiding this comment.
Interesting - it seems that this test class should have always thrown this (i.e. it was a minor bug in the test I think). Unless I'm missing something, nice work!
There was a problem hiding this comment.
I said myself the same when reading the code :)
jubianchi
changed the title
| } | ||
| } catch (TransformationFailedException $exception) { | ||
| throw new TransformationFailedException( | ||
| 'Unable to transform value for property path "' . $this->getPropertyPath() . '": ' . $exception->getMessage(), |
There was a problem hiding this comment.
this is a reverse transform now, I guess we could say "reverse" here :)
|
👍 |
1 similar comment
|
👍 |
|
Thank you @jubianchi. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2014
…providing property path (jubianchi) This PR was squashed before being merged into the 2.6-dev branch (closes #11318). Discussion ---------- [WIP][Form] Improve transformation failure message by providing property path | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | #11287 | License | MIT | Doc PR | Commits ------- d56b7be [WIP][Form] Improve transformation failure message by providing property path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.