[DependencyInjection] inlined factory not referenced #12393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boekkooi
force-pushed
the
di-factory-inline-patch
branch
from
8407681 to
806fbb7
Compare
boekkooi
changed the title
… a inlined definition
…n once within the same definition
boekkooi
force-pushed
the
di-factory-inline-patch
branch
from
9c1cb9b to
da6495b
Compare
|
This bug is related to #11639 sorry for not catching this inlined problem back then. |
|
@fabpot Is there anything I can do to move this PR along? |
|
Thank you @boekkooi. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2014
…kooi) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12393). Discussion ---------- [DependencyInjection] inlined factory not referenced | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While working with the DI I encountered a `You have requested a non-existent service "xxxxx"` exception. Research it seems that a private reference was inlined but the private factory that was also referencing to the service was ignored. A example of the problem: ```XML <service id="manager" class="\stdClass" factory-method="getX" factory-service="factory" public="false"> <argument>X</argument> </service> <service id="repository" class="\stdClass" factory-method="getRepository" factory-service="manager" public="false"> <argument>X</argument> </service> <service id="storage" class="\stdClass" public="false"> <argument type="service" id="manager"/> <argument type="service" id="repository"/> </service> ``` What happens before the patch: 1. repository get's inlined 2. manager get's inlined for the first argument 3. manager get's removed since there was no reference. After the first commit the following will happen: 1. repository get's inlined 2. manager get's inlined for the first argument 3. manager will not be removed since the inlined repository still references manager This introduced a smell since InlineServiceDefinitionsPass was still inlining the manager for the first argument. To fix this I have chosen that not inline factories if they are used more then once by the same definition. So after the second commit the following will happen: 1. repository get's inlined Personally I feel that the InlineServiceDefinitionsPass patch isn't the best possible one but that a different fix would probably mean breaking BC so it's probably a good idea to look at this for Symfony 3.0. Commits ------- 7816a98 [DependencyInjection] inlined factory not referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the DI I encountered a
You have requested a non-existent service "xxxxx"exception.Research it seems that a private reference was inlined but the private factory that was also referencing to the service was ignored.
A example of the problem:
What happens before the patch:
After the first commit the following will happen:
This introduced a smell since InlineServiceDefinitionsPass was still inlining the manager for the first argument.
To fix this I have chosen that not inline factories if they are used more then once by the same definition.
So after the second commit the following will happen:
Personally I feel that the InlineServiceDefinitionsPass patch isn't the best possible one but that a different fix would probably mean breaking BC so it's probably a good idea to look at this for Symfony 3.0.