[DX][Profiler] Show the inherited roles in the web profiler

[peterrehm]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#12892
License	MIT
Doc PR	-

Given the following role hierarchy configuration

security:
    role_hierarchy:
        ROLE_SUPER_ADMIN: [ROLE_ADMIN, ROLE_ALLOWED_TO_SWITCH]
        ROLE_ADMIN:       [ROLE_EMPLOYEE]
        ROLE_EMPLOYEE:    [ROLE_SALES]

If you were checking the user roles in the web profiler as an user with the assigned
role ROLE_ADMIN you saw only the following output.

This was kind of tricky since pages where you were checking is_granted('ROLE_EMPLOYEE')
granted access. Debugging was hard for newcomers to the project if they did not understand
the role hierarchy.

With this adjustment you will see the assigned roles as well as the inherited roles separately as
follows:

[fabpot]

Should accept null to keep BC, in which case, you just don't get the new feature.

[peterrehm]

Will fix right now. BC in case someone has defined his own Collector?

[fabpot]

That's needed also for Silex-WebProfiler for instance.

[fabpot]

Apparently, that breaks the tests.

[peterrehm]

@fabpot Yes, I had one local commit missing - now it should be okay.

[stof]

just use array_diff() instead of reimplementing in userland. This will be more readable, and the C implementation is likely to win over a userland implementation (even though I haven't benchmarked it and this is not critical here)

[peterrehm]

@stof Thanks for the valuable feedback, has been updated.

[fabpot]

@peterrehm Can you also have a look at the tests?

[peterrehm]

@fabpot It looks like they broke due to the switch to array_diff as suggested by @stof.
I reverted those changes to the userland implementation.

It is all due to the diff with objects

$role1 = new \Symfony\Component\Security\Core\Role\Role('ROLE_USER');

$assignedRoles = array($role1);
$allRoles = array($role1);

var_dump(array_diff($assignedRoles, $allRoles));

Fails with the following error:

PHP Catchable fatal error:  Object of class Symfony\Component\Security\Core\Role\Role could not be converted to string in /www/symfony/play.php on line 10

[peterrehm]

Now it should be okay. However there are many failing tests due to the depreciation messages.

[fabpot]

Thank you @peterrehm.