Fix the validation of form resources to register the default theme #15428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but a test would help to prevent further regressions |
|
👍 |
|
@javiereguiluz will do this evening |
stof
force-pushed
the
fix_config_validation
branch
from
2763fab to
ea92610
Compare
|
Updated with tests |
|
Good catch, thanks @stof. |
Tobion
added a commit
that referenced
this pull request
Aug 26, 2015
…lt theme (stof) This PR was merged into the 2.3 branch. Discussion ---------- Fix the validation of form resources to register the default theme | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a #14173 made some wrong changes, changing the behavior of the code. This reverts to the right behavior in affected places Commits ------- ea92610 Fix the validation of form resources to register the default theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14173 made some wrong changes, changing the behavior of the code. This reverts to the right behavior in affected places