Fix that two DirectoryResources with different patterns would be deduplicated #15718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicated ResourceInterface::__toString is mainly important because in various places, array_uniqe() is called to perform a de-duplication of resources and will use the string representation for objects. Thus, we need to take care that if DirectoryResources apply different patterns they must be kept after array_unique calls.
|
Fixed tickets pointing to the PR itself does not make sense |
|
anyway, 👍 |
|
should be merged in 2.3, right? |
|
@fabpot Right. Can you fix that or do you need a new PR? |
|
@mpdude I'm going to merge it in 2.3 myself, thanks. |
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2015
…uld be deduplicated (mpdude) This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15718). Discussion ---------- Fix that two DirectoryResources with different patterns would be deduplicated | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a ResourceInterface::__toString is mainly important because in various places, array_uniqe() is called to perform a de-duplication of resources and will use the string representation for objects. Thus, we need to take care that if DirectoryResources apply different patterns they must be kept after array_unique calls. Commits ------- 2b36ac5 Fix that two DirectoryResources with different patterns would be deduplicated
|
Merged in d8a801a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceInterface::__toString is mainly important because in various places, array_uniqe() is called to perform a de-duplication of resources and will use the string representation for objects.
Thus, we need to take care that if DirectoryResources apply different patterns they must be kept after array_unique calls.