Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] add support for parsing the !!binary tag #17863

Merged
merged 1 commit into from
Feb 28, 2016
Merged

[Yaml] add support for parsing the !!binary tag #17863

merged 1 commit into from
Feb 28, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 20, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8094, #15587, #17599
License MIT
Doc PR symfony/symfony-docs#6226

@xabbuh xabbuh added the Yaml label Feb 20, 2016
@xabbuh
Copy link
Member Author

xabbuh commented Feb 20, 2016

@stof In #17599 you suggested to dump binary strings with the !!binary tag. Do you have an idea how we can best detect such strings (dumping with the !!binary should still be an opt-in feature though in my opinion).

@javiereguiluz
Copy link
Member

👍 nice addition and perfectly tested! Thanks @xabbuh.

Status: reviewed

@stof
Copy link
Member

stof commented Feb 26, 2016

@xabbuh PHPUnit looks for control chars to detect binary strings

@xabbuh
Copy link
Member Author

xabbuh commented Feb 27, 2016

@stof Thanks for the tip. I added support for detecting binary data and dumping them as base64 encoded strings (as an opt-in feature).

@fabpot
Copy link
Member

fabpot commented Feb 28, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit 79a63d5 into symfony:master Feb 28, 2016
fabpot added a commit that referenced this pull request Feb 28, 2016
@fabpot
feature #17863 [Yaml] add support for parsing the !!binary tag (xabbuh)
c74f1aa 
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Yaml] add support for parsing the !!binary tag

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8094, #15587, #17599
| License       | MIT
| Doc PR        | TODO

Commits
-------

79a63d5 [Yaml] add support for the !!binary tag
@xabbuh xabbuh deleted the issue-15587 branch February 28, 2016 10:14
@xabbuh xabbuh mentioned this pull request Mar 1, 2016
Closed
7 tasks
@geek-merlin geek-merlin mentioned this pull request Mar 20, 2016
Closed
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xabbuh @javiereguiluz @stof @fabpot @carsonbot