Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][HttpKernel] Move ControllerArgumentValueResolverPass to the HttpKernel component #21815

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
5 participants
@chalasr
Copy link
Member

commented Mar 1, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
@chalasr

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2017

different failures are all unrelated, this is ready.

@chalasr chalasr force-pushed the chalasr:argvalresolverpass branch 5 times, most recently from bcfd2d5 to 7497d45 Mar 2, 2017

@chalasr chalasr force-pushed the chalasr:argvalresolverpass branch from 7497d45 to 8bad8a1 Mar 3, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 4, 2017

@nicolas-grekas
Copy link
Member

left a comment

👍

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 4, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 8bad8a1 into symfony:master Mar 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 4, 2017

feature #21815 [FrameworkBundle][HttpKernel] Move ControllerArgumentV…
…alueResolverPass to the HttpKernel component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][HttpKernel] Move ControllerArgumentValueResolverPass to the HttpKernel component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

8bad8a1 Move ControllerArgumentValueResolverPass to the HttpKernel component

@chalasr chalasr deleted the chalasr:argvalresolverpass branch Mar 4, 2017

@chalasr chalasr referenced this pull request Mar 6, 2017

Closed

[FrameworkBundle] Move compiler passes to their component #21284

11 of 11 tasks complete

@fabpot fabpot referenced this pull request May 1, 2017

Merged

Release v3.3.0-BETA1 #22603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.