New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port usage in server:status command #22172

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@alcaeus
Contributor

alcaeus commented Mar 27, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

This fixes a bug where running console server:status -p 8001 won't work because the port is already contained in the default value for address.

@alcaeus

This comment has been minimized.

Show comment
Hide comment
@alcaeus

alcaeus Mar 27, 2017

Contributor

No idea what the build failure on PHP 7 is about - travis is not giving any output.

Edit: travis gives build errors, not sure they are related to the PR though. Couldn't reproduce them on PHP 7 locally.

Contributor

alcaeus commented Mar 27, 2017

No idea what the build failure on PHP 7 is about - travis is not giving any output.

Edit: travis gives build errors, not sure they are related to the PR though. Couldn't reproduce them on PHP 7 locally.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Mar 27, 2017

Member

Thank you @alcaeus.

Member

fabpot commented Mar 27, 2017

Thank you @alcaeus.

@fabpot fabpot merged commit dbcfa5c into symfony:2.7 Mar 27, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 27, 2017

bug #22172 Fix port usage in server:status command (alcaeus)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix port usage in server:status command

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This fixes a bug where running `console server:status -p 8001` won't work because the port is already contained in the default value for `address`.

Commits
-------

dbcfa5c Remove port from default host in server:status command

@alcaeus alcaeus deleted the alcaeus:fix-server-status-default-host branch Mar 27, 2017

This was referenced Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment