CI fixes #22754
CI fixes #22754
Conversation
nicolas-grekas
commented
May 18, 2017
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -31,11 +31,11 @@ protected function setUp() | |||
| { | |||
| parent::setUp(); | |||
|
|
|||
| if (!extension_loaded('mongo') && !extension_loaded('mongodb')) { | |||
| if (!extension_loaded('mongo') && (!extension_loaded('mongodb') || !class_exists('MongoDB\Client', false))) { | |||
There was a problem hiding this comment.
For PHP7, I would check separately whether the PHP extension is installed or the userland library (mongodb/mongodb) in two different steps. Users which did not install the userland library may not understand that they also need to install it in addition to the PHP "mongodb" extension.
There was a problem hiding this comment.
Actually, generally speaking, the mongo extension should no longer be used. It is actually flagged as legacy since it does not support MongoDB 3.2 and 3.4, and won't be updated anymore.
Please check the drivers compatibility matrix for more information regarding versions supported (https://docs.mongodb.com/ecosystem/drivers/driver-compatibility-reference/#php-driver-compatibility)
|
@csarrazi green :) thanks for your help (we have to keep mongo.so as it works and has to be supported) |
|
Thank you @nicolas-grekas. |
This PR was merged into the 2.7 branch. Discussion ---------- CI fixes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a34b8ce CI fixes
|
@nicolas-grekas No problem! As mentioned on Twitter, I'll try to submit a PR to deprecate the legacy |
