[Filesystem] silence notice from tempnam on PHP7.1+ #22923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP7.1 changed the behavior of tempnam() to report a notice when it falls back to the system temp directory: https://bugs.php.net/bug.php?id=69489. Silence the notice, as otherwise a testcase failure occurs with PHP7.1+. This was seen while updating Symfony on Ubuntu 17.10 (with PHP 7.1.5). Signed-off-by: Nishanth Aravamudan <nish.aravamudan@canonical.com>
|
Since v2.8.9, the call to |
|
On May 28, 2017 02:29, "Nicolas Grekas" <notifications@github.com> wrote:
Since v2.8.9, the call to tempnam() is already silenced, see
https://github.com/symfony/symfony/blob/321e41cb6b6396acfd77f9a5d5277c
87543bcb85/src/Symfony/Component/Filesystem/Filesystem.php#L525
Oh! I'm very sorry for the noise, I looked at the wrong code before sending
the PR.
…-Nish
|
|
@nicolas-grekas It seems there's another Should that be silenced too? If so, I can create a PR. |
|
You can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7.1 changed the behavior of tempnam() to report a notice when it
falls back to the system temp directory:
https://bugs.php.net/bug.php?id=69489. Silence the notice, as otherwise
a testcase failure occurs with PHP7.1+. This was seen while updating
Symfony on Ubuntu 17.04 (with PHP 7.1.5).
Signed-off-by: Nishanth Aravamudan nish.aravamudan@canonical.com
I am updating Symfony to match Debian (2.8.7) in Ubuntu 17.10. This mostly worked, with some additional backports, as we only support PHP7.1 in 17.10. However, it seems that PHP has changed tempnam() to emit a notice when it falls back, which leads to a testcase failure.