New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fixed options stub values display in form profiler #22928

Merged
merged 1 commit into from May 28, 2017

Conversation

Projects
None yet
3 participants
@HeahDude
Member

HeahDude commented May 28, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

Since 3.3 and #21638, serializing form options gives either a CutStub instance or a simple var, ref ab716c6#diff-78ea21636d0319e1c804ccc1a33f68f3R271.

This breaks the form profiler panel.

@HeahDude HeahDude changed the title from Fixed options stub values display in form profiler to [WebProfilerBundle] Fixed options stub values display in form profiler May 28, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone May 28, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented May 28, 2017

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit 5e6b3a5 into symfony:3.3 May 28, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 28, 2017

bug #22928 [WebProfilerBundle] Fixed options stub values display in f…
…orm profiler (HeahDude)

This PR was merged into the 3.3 branch.

Discussion
----------

[WebProfilerBundle] Fixed options stub values display in form profiler

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Since 3.3 and #21638, serializing form options gives either a `CutStub` instance or a simple var, ref ab716c6#diff-78ea21636d0319e1c804ccc1a33f68f3R271.

This breaks the form profiler panel.

Commits
-------

5e6b3a5 Fixed options stub values display in form profiler

@HeahDude HeahDude deleted the HeahDude:fix/form-profiler branch May 28, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment