[Console] Initialize lazily to render exceptions properly #23909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
console-early-x
branch
from
d06cbbb
to
62174fd
Compare
chalasr
approved these changes
Aug 17, 2017
stof
approved these changes
Aug 17, 2017
ogizanagi
approved these changes
Aug 17, 2017
|
Thank you @nicolas-grekas. |
chalasr
added a commit
that referenced
this pull request
Aug 17, 2017
…(nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Initialize lazily to render exceptions properly | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When an exception occurs in the constructor of an `Application`, exception handling is not yet set up. This typically happens when the container cannot be build for some reason, where calling `$this->add()` builds the container and fails. This PR makes initialization lazy so that it happens later on, when exception handling might be OK. Before:  After:  Commits ------- 62174fd [Console] Initialize lazily to render exceptions properly
This was referenced Aug 28, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception occurs in the constructor of an
Application, exception handling is not yet set up.This typically happens when the container cannot be build for some reason, where calling
$this->add()builds the container and fails.This PR makes initialization lazy so that it happens later on, when exception handling might be OK.
Before:
After:
