New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Added missing link to profile token #24237

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
8 participants
@vtsykun
Contributor

vtsykun commented Sep 17, 2017

Q A
Branch? 3.3
Bug fix? yes, it was on 3.3.6 (before merge #23676)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

On v3.3.6 I can open profiles for sub-request on this link
selection_188

But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile
selection_186

@ro0NL

ro0NL approved these changes Sep 18, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Sep 18, 2017

@xabbuh

xabbuh approved these changes Sep 20, 2017

@stof

stof approved these changes Sep 20, 2017

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz Sep 27, 2017

Member

Thank you @vtsykun.

Member

javiereguiluz commented Sep 27, 2017

Thank you @vtsykun.

@javiereguiluz javiereguiluz merged commit c388b25 into symfony:3.3 Sep 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

javiereguiluz added a commit that referenced this pull request Sep 27, 2017

bug #24237 [WebProfilerBundle] Added missing link to profile token (v…
…tsykun)

This PR was merged into the 3.3 branch.

Discussion
----------

[WebProfilerBundle] Added missing link to profile token

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes, it was on 3.3.6 (before merge #23676)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

On v3.3.6 I can open profiles for sub-request on this link
![selection_188](https://user-images.githubusercontent.com/21358010/30518552-dc6a1f72-9b89-11e7-9d2f-d348846d7285.png)

But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile
![selection_186](https://user-images.githubusercontent.com/21358010/30518572-7a1420c4-9b8a-11e7-8514-098c4ec2c3d6.png)

Commits
-------

c388b25 [WebProfilerBundle] Added missing link to profile token

@vtsykun vtsykun deleted the vtsykun:profiler-missing-link branch Sep 27, 2017

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018

bug #24237 [WebProfilerBundle] Added missing link to profile token (v…
…tsykun)

This PR was merged into the 3.3 branch.

Discussion
----------

[WebProfilerBundle] Added missing link to profile token

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes, it was on 3.3.6 (before merge symfony#23676)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

On v3.3.6 I can open profiles for sub-request on this link
![selection_188](https://user-images.githubusercontent.com/21358010/30518552-dc6a1f72-9b89-11e7-9d2f-d348846d7285.png)

But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile
![selection_186](https://user-images.githubusercontent.com/21358010/30518572-7a1420c4-9b8a-11e7-8514-098c4ec2c3d6.png)

Commits
-------

c388b25 [WebProfilerBundle] Added missing link to profile token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment