[Doctrine Bridge] EntityType : default choices value #2500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd try query_builder or findAll. We should use false instead of array() to mean that we don't use the choices property.
…nd try query_builder or findAll. We should use false instead of array() to mean that we don't use the choices property.
|
As this is a bug fix, can you open a new PR on the 2.0 branch? Also, if you can add some unit tests, that would be even better. Thanks. |
|
New PR created on branch 2.0: #2504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the choices property is equal to array(), the EntityChoiceList don't use empty choices and try query_builder or findAll.
We should use false as default instead of array() to be able to have an empty list if a custom filter give an empty result. With array() as default, the EntityType populates choices with findAll even if our result was empty; and it is not expected.