New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] turn $private to protected in dumped container, to make cache:clear BC #25268

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
7 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 2, 2017

Q A
Branch? 4.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Turning this property to protected changes nothing to its visibility in practice as the class is final anyway,
but when migrating to SF4.0 from 3.4, the cache:clear command chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected".

Let's make it protected to remove this WTF.

@dunglas

dunglas approved these changes Dec 2, 2017

@chalasr

chalasr approved these changes Dec 2, 2017

@nicolas-grekas nicolas-grekas changed the title from [DI] turn $private to protected in dumped container, to make cache:cl… to [DI] turn $private to protected in dumped container, to make cache:clear BC Dec 3, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 3, 2017

Member

Comment added.

Status: needs review

Member

nicolas-grekas commented Dec 3, 2017

Comment added.

Status: needs review

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.0 Dec 3, 2017

@fabpot

fabpot approved these changes Dec 4, 2017

@stof

stof approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 4, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Dec 4, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c98d967 into symfony:4.0 Dec 4, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

bug #25268 [DI] turn $private to protected in dumped container, to ma…
…ke cache:clear BC (nicolas-grekas)

This PR was merged into the 4.0 branch.

Discussion
----------

[DI] turn $private to protected in dumped container, to make cache:clear BC

| Q             | A
| ------------- | ---
| Branch?       | 4.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Turning this property to protected changes nothing to its visibility in practice as the class is final anyway,
but when migrating to SF4.0 from 3.4, the `cache:clear` command chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected".

Let's make it protected to remove this WTF.

Commits
-------

c98d967 [DI] turn $private to protected in dumped container, to make cache:clear BC

@fabpot fabpot referenced this pull request Dec 5, 2017

Merged

Release v4.0.1 #25322

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-protected-privates branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment