[DI] Impossible to set an environment variable and then an array as container parameter #25333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phantas0s
changed the title
|
Could you change the base branch of your PR to 3.3? |
done :) |
ro0NL
reviewed
Dec 5, 2017
| @@ -615,6 +615,20 @@ public function testResolveEnvValues() | |||
| unset($_ENV['DUMMY_ENV_VAR'], $_SERVER['DUMMY_SERVER_VAR'], $_SERVER['HTTP_DUMMY_VAR']); | |||
| } | |||
|
|
|||
| public function testResolveEnvValuesWithArray() | |||
There was a problem hiding this comment.
risky test btw.. needs an assertion.
There was a problem hiding this comment.
You definitely need to assert something.
There was a problem hiding this comment.
I did some assertions. Sorry for that.
sroze
suggested changes
Dec 5, 2017
| @@ -615,6 +615,20 @@ public function testResolveEnvValues() | |||
| unset($_ENV['DUMMY_ENV_VAR'], $_SERVER['DUMMY_SERVER_VAR'], $_SERVER['HTTP_DUMMY_VAR']); | |||
| } | |||
|
|
|||
| public function testResolveEnvValuesWithArray() | |||
There was a problem hiding this comment.
You definitely need to assert something.
|
Sorry I definitely didn't follow correctly the guideline for pull request... I will do better next time :) |
fabpot
approved these changes
Dec 11, 2017
|
Thank you @Phantas0s. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
… array as container parameter (Phantas0s) This PR was squashed before being merged into the 3.3 branch (closes #25333). Discussion ---------- [DI] Impossible to set an environment variable and then an array as container parameter | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25245 | License | MIT When an environment variables and then an array is set as container parameters, an error is thrown (Warning: stripos() expects parameter 1 to be string, array given). You can run my test without the fix in the Container builder to see it. Commits ------- 484a082 [DI] Impossible to set an environment variable and then an array as container parameter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an environment variables and then an array is set as container parameters, an error is thrown (Warning: stripos() expects parameter 1 to be string, array given).
You can run my test without the fix in the Container builder to see it.