Skip to content

[HttpFoundation] Add immutable to setCache's PHPDoc #25455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

[HttpFoundation] Add immutable to setCache's PHPDoc #25455

merged 1 commit into from
Dec 12, 2017

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Dec 12, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@xabbuh xabbuh added this to the 3.4 milestone Dec 12, 2017
@nicolas-grekas
Copy link
Member

Thank you @dunglas.

@nicolas-grekas nicolas-grekas merged commit 6e248ca into symfony:3.4 Dec 12, 2017
nicolas-grekas added a commit that referenced this pull request Dec 12, 2017
@nicolas-grekas
minor #25455 [HttpFoundation] Add immutable to setCache's PHPDoc (dun…
8151661 
…glas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Add immutable to setCache's PHPDoc

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

6e248ca [HttpFoundation] Add immutable to setCache's PHPDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@Simperfit Simperfit Simperfit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
HttpFoundation Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@dunglas @nicolas-grekas @javiereguiluz @xabbuh @Simperfit @carsonbot