Updating message to inform the user how to install the component #25606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure looks unrelated |
javiereguiluz
approved these changes
Dec 27, 2017
Simperfit
reviewed
Dec 27, 2017
| if (!class_exists('Symfony\\Component\\CssSelector\\CssSelectorConverter')) { | ||
| throw new \RuntimeException('Unable to filter with a CSS selector as the Symfony CssSelector 2.8+ is not installed (you can use filterXPath instead).'); | ||
| if (!class_exists(CssSelectorConverter::class)) { | ||
| throw new \RuntimeException('To filter with a CSS selector, install the CssSelector component ("composer require symfony/css-selector"). Or use filterXpath instead.'); |
xabbuh
approved these changes
Dec 27, 2017
|
Thank you @weaverryan. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 27, 2017
…ponent (weaverryan) This PR was submitted for the 4.0 branch but it was squashed and merged into the 3.4 branch instead (closes #25606). Discussion ---------- Updating message to inform the user how to install the component | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Simple: direct the user exactly what to do if they hit this :) Commits ------- 07ac535 Updating message to inform the user how to install the component
|
merged into 3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple: direct the user exactly what to do if they hit this :)