[OptionsResolver] Fix options resolver with array allowed types #25763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
fix-options-resolver-with-array-allowed-types
branch
from
1e46b19
to
cc215f7
Compare
mcg-web
changed the title
mcg-web
changed the title
nicolas-grekas
approved these changes
Jan 16, 2018
soullivaneuh
approved these changes
Jan 17, 2018
|
@mcg-web Is any workaround possible waiting this PR getting merged and released? |
This was referenced Jan 17, 2018
|
@soullivaneuh this PR is just a fix so this is totally ready for merge |
fabpot
approved these changes
Jan 17, 2018
|
Thank you @mcg-web. |
fabpot
added a commit
that referenced
this pull request
Jan 17, 2018
…types (mcg-web)
This PR was merged into the 3.4 branch.
Discussion
----------
[OptionsResolver] Fix options resolver with array allowed types
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
When playing a simple test:
```php
use Symfony\Component\OptionsResolver\Options;
$resolver = new OptionsResolver();
$resolver->setDefined('foo');
$resolver->setAllowedTypes('foo', 'string[]');
$options = $resolver->resolve(['foo' => ['bar', 'baz']]);
```
I get this error:
```
Symfony\Component\OptionsResolver\Exception\InvalidOptionsException: The option "foo" with value array is expected to be of type "string[]", but is of type "string[]"
```
This PR should fix this.
Commits
-------
cc215f7 Fix options resolver with array allowed types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing a simple test:
I get this error:
This PR should fix this.