[Form][WCAG] Fixed HTML errors #26328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 26, 2018
|
This one is indeed rather odd. Anyway, let's merge this one in 3.4. I would also change the other forms, but only on master (4.1). |
fabpot
approved these changes
Feb 27, 2018
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Feb 27, 2018
This PR was squashed before being merged into the 3.4 branch (closes #26328). Discussion ---------- [Form][WCAG] Fixed HTML errors | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability): > Fix your HTML errors. Should I fix the same issues on other forms as well? Or could someone claim that is a BC break? Commits ------- fe66819 [Form][WCAG] Fixed HTML errors
|
Thank you for merging. I'll fix the other forms as well |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [FORM] Fix HTML errors. | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | As mentioned in #26328. Range and color do not support "required" attribute Commits ------- f75d8c1 Fix HTML errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my friend and WCAG2 expect Sandra:
Should I fix the same issues on other forms as well? Or could someone claim that is a BC break?