[DI] Skip resource tracking if disabled #26393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Mar 4, 2018
chalasr
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26388 |
| License | MIT |
| Doc PR | n/a |
| $resource = new ClassExistenceResource($class, false); | ||
| $classReflector = $resource->isFresh(0) ? false : new \ReflectionClass($class); | ||
| } else { | ||
| $classReflector = new \ReflectionClass($class); |
There was a problem hiding this comment.
Should be false if the clas/interface/traits doesn't exist
There was a problem hiding this comment.
happens in catch no? L359 here.
Simperfit
approved these changes
Mar 4, 2018
fabpot
approved these changes
Mar 5, 2018
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Mar 5, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Skip resource tracking if disabled | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26388 | License | MIT | Doc PR | n/a Commits ------- 0b748fa [DI] Skip resource tracking if disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.