Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitBridge] Fix ClockMock microtime() format #28648

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@acasademont
Copy link
Contributor

commented Sep 30, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

This is a follow-up PR to #27890 to fix the microtime precision, it should be 8 decimals instead of the current 6 (see https://3v4l.org/GYacF)

The problem now is that due to the new tests the whole testsuite will fail if run from the main directory, as hhvm and 5.4 targets are doing, due to phpunit using the wrong ClockMock class. Tests for 7.1 and 7.2 pass because they cd into the component directory.

@acasademont acasademont force-pushed the acasademont:fix_microtime_format branch from 2f47fa0 to e3732b6 Sep 30, 2018

@acasademont acasademont changed the title [PHPUnitBridge] Fix microtime() format [PHPUnitBridge] Fix ClockMock microtime() format Sep 30, 2018

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Sep 30, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

Thank you @acasademont.

@nicolas-grekas nicolas-grekas merged commit e3732b6 into symfony:2.8 Oct 2, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Oct 2, 2018

bug #28648 [PHPUnitBridge] Fix ClockMock microtime() format (acasadem…
…ont)

This PR was merged into the 2.8 branch.

Discussion
----------

[PHPUnitBridge] Fix ClockMock microtime() format

| Q             | A
| ------------- | ---
| Branch?       | 2.8 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | no    <!-- please add some, will be required by reviewers -->
| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | <!-- required for new features -->

This is a follow-up PR to #27890 to fix the `microtime` precision, it should be 8 decimals instead of the current 6 (see https://3v4l.org/GYacF)

The problem now is that due to the new tests the whole testsuite will fail if run from the main directory, as hhvm and 5.4 targets are doing, due to phpunit using the wrong `ClockMock` class. Tests for 7.1 and 7.2 pass because they `cd` into the component directory.

Commits
-------

e3732b6 [PHPUnitBridge] Fix microtime() format

This was referenced Oct 3, 2018

@fabpot fabpot referenced this pull request Nov 3, 2018

Merged

Release v2.8.47 #29069

@acasademont acasademont deleted the acasademont:fix_microtime_format branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.