Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Stop calling Kernel::boot() twice in cli #29541

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

commented Dec 9, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29505
License MIT
Doc PR n/a

Allows custom Kernel::boot() implementations to not be aware of the protected Kernel::$booted prop.

@chalasr chalasr added this to the next milestone Dec 9, 2018

@chalasr chalasr force-pushed the chalasr:fix-cli-doubleboot branch from 1db8baf to 97e15fe Dec 9, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Thank you @chalasr.

@fabpot fabpot merged commit 97e15fe into symfony:master Dec 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 10, 2018

feature #29541 [FrameworkBundle] Stop calling Kernel::boot() twice in…
… cli (chalasr)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] Stop calling Kernel::boot() twice in cli

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29505
| License       | MIT
| Doc PR        | n/a

Allows custom `Kernel::boot()` implementations to not be aware of the protected `Kernel::$booted` prop.

Commits
-------

97e15fe [FrameworkBundle] Stop calling Kernel::boot() twice in cli

@chalasr chalasr deleted the chalasr:fix-cli-doubleboot branch Dec 10, 2018

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.