Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Console] Added suggestions for missing packages #29865
Currently, when someone runs one of the most common commands, e.g.
This commit adds a more useful message, informing the user about a package that might be missing and suggesting a command that should be run in order to install it, e.g.
I like the idea.
i'd prefer something like we did for twig: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Twig/UndefinedCallableHandler.php
i think its more straightforward to handle it in e.g. a catch-all event listener for unknown commands, opposed to tracking a list on high level (console application).
I had some doubts adding it to the main application, since it is widely used as a standalone component, but I wanted the suggestions to be available for some, who started his project with a symfony/skeleton (so without the FrameworkBundle) and tries to use features, that are not installed.
By the way, can you tell me, why my CI checks failed? Did I forget about something in my PR?
I improved the logic. For example, when someone has WebServerBundle and runs
2 times, most recently
Jan 17, 2019
referenced this pull request
Jan 18, 2019
Status: Needs Review
Status: Needs Work
Jan 20, 2019
Too many reviews in a short period of time and things got a little messy for a moment. I've implemented all suggestions the code, fixed the tests. The one Travis CI test that fails, failed before and I guess it has nothing to do with my code directly.
The only thing left to decide is whether to put