Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Added missing use statement for UnexpectedTypeException #30273

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
3 participants
@devrck
Copy link
Contributor

devrck commented Feb 16, 2019

Q A
Branch? 4.2 (be careful when merging)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Added a simple use statement that I saw it was not added, can't elaborate more than that 馃槃 .

@chalasr
Copy link
Member

chalasr left a comment

For 4.2.

@chalasr chalasr force-pushed the devrck:countvalidator-missing-use-statement branch from 42a5fba to d10347f Feb 16, 2019

@chalasr chalasr changed the base branch from master to 4.2 Feb 16, 2019

@chalasr

This comment has been minimized.

Copy link
Member

chalasr commented Feb 16, 2019

Good catch, thanks @devrck.

@chalasr chalasr merged commit d10347f into symfony:4.2 Feb 16, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request Feb 16, 2019

bug #30273 [Validator] Added missing use statement for UnexpectedType鈥
鈥xception (devrck)

This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #30273).

Discussion
----------

[Validator] Added missing use statement for UnexpectedTypeException

| Q             | A
| ------------- | ---
| Branch?       | 4.2 (be careful when merging)
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Added a simple use statement that I saw it was not added, can't elaborate more than that 馃槃 .

Commits
-------

d10347f [Validator] Added missing use statement for UnexpectedTypeException

@fabpot fabpot referenced this pull request Mar 3, 2019

Merged

Release v4.2.4 #30431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.