[Form] Added ResetInterface to CachingFactoryDecorator #30597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Mar 19, 2019
|
Shouldn't we tag the corresponding service as |
HeahDude
force-pushed
the
form/cache-decorator-reset
branch
from
4574179
to
1f8d67a
Compare
|
Done too. Thanks! |
fabpot
approved these changes
Mar 19, 2019
HeahDude
force-pushed
the
form/cache-decorator-reset
branch
from
1f8d67a
to
4ddf5a1
Compare
HeahDude
commented
Mar 19, 2019
| @@ -410,6 +411,11 @@ private function registerFormConfiguration(array $config, ContainerBuilder $cont | |||
| if (!class_exists(Translator::class)) { | |||
| $container->removeDefinition('form.type_extension.upload.validator'); | |||
| } | |||
| if (!method_exists(CachingFactoryDecorator::class, 'reset')) { | |||
There was a problem hiding this comment.
So I guess this can be reverted when merged in master.
xabbuh
approved these changes
Mar 19, 2019
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 20, 2019
…ahDude) This PR was merged into the 4.2 branch. Discussion ---------- [Form] Added ResetInterface to CachingFactoryDecorator | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29259 | License | MIT | Doc PR | ~ I don't know if this should be considered a feature and target master, but I tend to see it as a bug fix. Commits ------- 4ddf5a1 [Form] Added ResetInterface to CachingFactoryDecorator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this should be considered a feature and target master, but I tend to see it as a bug fix.