[Inflector] remove "internal" marker from the component #30810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
inflector
branch
from
dede762
to
164b45b
Compare
fabpot
approved these changes
Apr 1, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 1, 2019
…t (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [Inflector] remove "internal" marker from the component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26903 | License | MIT | Doc PR | - This code works: making it non-internal won't increase the maintenance burden and can help others build on it. Commits ------- 164b45b [Inflector] remove "internal" marker from the component
Merged
andrew-demb
reviewed
Jul 15, 2024
| @@ -58,7 +58,7 @@ public function singularizeProvider() | |||
| ['crises', ['cris', 'crise', 'crisis']], | |||
| ['criteria', ['criterion', 'criterium']], | |||
| ['cups', 'cup'], | |||
| ['data', ['daton', 'datum']], | |||
There was a problem hiding this comment.
Why was this test changed?
Previously issues with singular datum were considered as a "feature" - #17764 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code works: making it non-internal won't increase the maintenance burden and can help others build on it.