Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inflector] remove "internal" marker from the component #30810

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Apr 1, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26903
License MIT
Doc PR -

This code works: making it non-internal won't increase the maintenance burden and can help others build on it.

@fabpot

fabpot approved these changes Apr 1, 2019

Copy link
Member

left a comment

... once the tests pass

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:inflector branch from dede762 to 164b45b Apr 1, 2019

@fabpot

fabpot approved these changes Apr 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 164b45b into symfony:master Apr 1, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Apr 1, 2019

feature #30810 [Inflector] remove "internal" marker from the componen…
…t (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Inflector] remove "internal" marker from the component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26903
| License       | MIT
| Doc PR        | -

This code works: making it non-internal won't increase the maintenance burden and can help others build on it.

Commits
-------

164b45b [Inflector] remove "internal" marker from the component

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:inflector branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.