Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] fix tests #31091

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Apr 12, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Follows twigphp/Twig#2935

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 12, 2019

@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig-fix-tests branch from e31a9f0 to 6ea7068 Apr 12, 2019

@fabpot

fabpot approved these changes Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig-fix-tests branch 4 times, most recently from 1008d74 to d8767ec Apr 12, 2019

@xabbuh

xabbuh approved these changes Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig-fix-tests branch from d8767ec to cfc3f7c Apr 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:twig-fix-tests branch from cfc3f7c to 33c6681 Apr 12, 2019

@nicolas-grekas nicolas-grekas merged commit 33c6681 into symfony:3.4 Apr 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Apr 12, 2019

minor #31091 [TwigBridge] fix tests (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Follows twigphp/Twig#2935

Commits
-------

33c6681 [TwigBridge] fix tests

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:twig-fix-tests branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.