[Intl] Extra timezone tests #31325
Merged
[Intl] Extra timezone tests #31325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Apr 30, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Apr 30, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Intl] Extra timezone tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (including intl-data group) | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Guarantees timezone data integrity. Ideally to go before #31292 :) Commits ------- a3cac2b [Intl] Extra timezone tests
stof
reviewed
Apr 30, 2019
| { | ||
| try { | ||
| $this->assertInternalType('string', Timezones::getCountryCode($timezone)); | ||
| } catch (MissingResourceException $e) { |
There was a problem hiding this comment.
if it is possible for valid timezone ids to throw a MissingResourceException when trying to get their code, we need to document that in the interface, as it becomes necessary to catch it when using it (or maybe the Timezones class should handle that internally)
stof
reviewed
Apr 30, 2019
| */ | ||
| public function testGetGmtOffsetAvailability(string $timezone) | ||
| { | ||
| $this->assertInternalType('int', Timezones::getRawOffset($timezone)); |
There was a problem hiding this comment.
shouldn't we ensure that with return types instead ?
Merged
fabpot
added a commit
that referenced
this pull request
May 1, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #31332). Discussion ---------- [Intl] Add phpdoc | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31325 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 22a6f7b [Intl] Add phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarantees timezone data integrity. Ideally to go before #31292 :)