Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Allow intl timezones #31292

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@ro0NL
Copy link
Contributor

commented Apr 27, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ref #28836
License MIT
Doc PR symfony/symfony-docs#11502

This PR considers the ICU timezones (#28831) as valid, as well as the PHP ones.

Both can be used in DateTimeZone, but expired timezones cannot be used with IntlTimeZone. The intlCompatibility option ensures compatibility between both.

Practically this allows for both UTC and Etc/UTC, where the latter should be preferred. I.e. currently Etc/UTC is considered an invalid timezone ... which it's not.

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 29, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-validator branch 2 times, most recently from a47e85b to 7bf0bfe Apr 29, 2019

weaverryan pushed a commit to weaverryan/symfony that referenced this pull request Apr 30, 2019

minor symfony#31324 [Validator] Extra timezone tests (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Extra timezone tests

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR adds some extra tests, to cover the timezone domain. Ideally to go before symfony#31292 :)

Commits
-------

4f2bba7 [Validator] Extra timezone tests

fabpot added a commit that referenced this pull request Apr 30, 2019

bug #31325 [Intl] Extra timezone tests (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Extra timezone tests

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes   (including intl-data group)
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Guarantees timezone data integrity. Ideally to go before #31292 :)

Commits
-------

a3cac2b [Intl] Extra timezone tests

@ro0NL ro0NL force-pushed the ro0NL:tz-validator branch 3 times, most recently from 8770eb6 to ea2ac8b Apr 30, 2019

@ro0NL ro0NL force-pushed the ro0NL:tz-validator branch from ea2ac8b to 7294b59 Apr 30, 2019

@fabpot

fabpot approved these changes May 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 7294b59 into symfony:master May 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 1, 2019

feature #31292 [Validator] Allow intl timezones (ro0NL)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Allow intl timezones

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | ref #28836
| License       | MIT
| Doc PR        | symfony/symfony-docs#11502

This PR considers the ICU timezones (#28831) as valid, as well as the PHP ones.

Both can be used in `DateTimeZone`, but expired timezones cannot be used with `IntlTimeZone`. The `intlCompatibility` option ensures compatibility between both.

Practically this allows for both `UTC` and `Etc/UTC`, where the latter should be preferred. I.e. currently `Etc/UTC` is considered an invalid timezone ... which it's not.

Commits
-------

7294b59 [Validator] Allow intl timezones

@ro0NL ro0NL deleted the ro0NL:tz-validator branch May 1, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.