Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] default to service id - *not* FQCN - when building tagged locators #31463

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented May 10, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

While reviewing #30926 I realized that defaulting to the FQCN is a shortcut that isn't useful enough.
Defaulting to the service id provides the same experience in practice because service ids are FQCN by default.
But when they aren't, the service id is the proper index to default to when building the locator.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:tagge-locator-by-id branch from 8675b24 to 52e827c May 11, 2019

@fabpot

fabpot approved these changes May 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 52e827c into symfony:4.3 May 13, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 13, 2019

bug #31463 [DI] default to service id - *not* FQCN - when building ta…
…gged locators (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[DI] default to service id - *not* FQCN - when building tagged locators

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

While reviewing #30926 I realized that defaulting to the FQCN is a shortcut that isn't useful enough.
Defaulting to the service id provides the same experience in practice because service ids are FQCN by default.
But when they aren't, the service id is the proper index to default to when building the locator.

Commits
-------

52e827c [DI] default to service id - *not* FQCN - when building tagged locators

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:tagge-locator-by-id branch May 13, 2019

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.