[Messenger] Fix missing auto_setup for RedisTransport #31621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
suggested changes
May 26, 2019
chalasr
force-pushed
the
msg-redis-autosetup
branch
from
07fa05b to
e9a44e6
Compare
chalasr
force-pushed
the
msg-redis-autosetup
branch
from
e9a44e6 to
d27bc2a
Compare
alexander-schranz
approved these changes
May 26, 2019
maxhelias
approved these changes
May 26, 2019
fabpot
approved these changes
May 27, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 27, 2019
…lasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix missing auto_setup for RedisTransport | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Should be my last PR for messenger 4.3's Redis transport :) Not having it makes it inconsistent with other transports and is especially annoying in tests. Commits ------- d27bc2a [Messenger] Fix missing auto_setup for RedisTransport
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be my last PR for messenger 4.3's Redis transport :)
Not having it makes it inconsistent with other transports and is especially annoying in tests.