Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] Set default crypto method #31846

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@bpolaszek
Copy link
Contributor

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31105
License MIT
Doc PR -

This PR fixes #31105 by providing STREAM_CRYPTO_METHOD_TLS_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT as default crypto method when none is defined in user options and TLS is enabled.

@bpolaszek bpolaszek changed the title Set default crypto method - Fix #31105 [Mailer] Set default crypto method - Fix #31105 Jun 4, 2019

@bpolaszek bpolaszek changed the title [Mailer] Set default crypto method - Fix #31105 [Mailer] Set default crypto method Jun 4, 2019

@bpolaszek bpolaszek force-pushed the bpolaszek:mailer-crypto-type branch from 3a678a9 to 58fe3b4 Jun 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

@bpolaszek Looks like an unrelated commit is part of your PR now (from a PR I've just merged).

@bpolaszek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

@fabpot Yes, since travis and appveyor failed on my 2nd commit, I tried to rebase and it looks like it's all messed up... I'm trying again.

@bpolaszek bpolaszek force-pushed the bpolaszek:mailer-crypto-type branch from bc89e1d to 4f0ad25 Jun 4, 2019

@bpolaszek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Well, builds are still failing but I don't think it's related.

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @bpolaszek.

@fabpot fabpot merged commit 4f0ad25 into symfony:4.3 Jun 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31846 [Mailer] Set default crypto method (bpolaszek)
This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] Set default crypto method

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31105
| License | MIT
| Doc PR | -

This PR fixes #31105 by providing `STREAM_CRYPTO_METHOD_TLS_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT` as  default crypto method when none is defined in user options and TLS is enabled.

Commits
-------

4f0ad25 Set default crypto method - Fix #31105

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

@xavismeh

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Works now like a charm using Amazon SES transport — which relays on (e)smtp transport. Thank you @bpolaszek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.