Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add couchbase cache adapter. #32039

Open
wants to merge 13 commits into
base: 4.4
from

Conversation

Projects
None yet
3 participants
@ajcerezo
Copy link

commented Jun 14, 2019

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #32038
License MIT
Doc PR symfony/symfony-docs#11748

Add new cache adapter to be able using Couchbase as cache system.

@nicolas-grekas
Copy link
Member

left a comment

Thanks for working on this.
Can you ensure the .travis.yml file is configured to run the tests for the new adapter please?

@ajcerezo ajcerezo changed the title Add couchbase cache adapter. [WIP] Add couchbase cache adapter. Jun 19, 2019

@ajcerezo ajcerezo changed the title [WIP] Add couchbase cache adapter. WIP: Add couchbase cache adapter. Jun 19, 2019

@ajcerezo ajcerezo force-pushed the ajcerezo:feature/add-cache-couchbase-bucket-adapter branch 2 times, most recently from 98e5087 to 1dedab0 Jun 24, 2019

@ajcerezo

This comment has been minimized.

Copy link
Author

commented Jul 4, 2019

Hi @nicolas-grekas ,
The integration tests with travis do not work, but I do not understand why it fails, since I have not changed anything in the Mailer component.
The error it gives is the following:

1) Symfony\Component\Mailer\Tests\TransportTest::testFromDsnMailgun
TypeError: Argument 4 passed to Symfony\Component\Mailer\Bridge\Mailgun\Smtp\MailgunTransport::__construct() must implement interface Psr\Log\LoggerInterface or be null, instance of Mock_EventDispatcherInterface_fc379422 given, called in /home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php on line 104
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/vendor/symfony/mailgun-mailer/Smtp/MailgunTransport.php:25
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:104
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:58
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Tests/TransportTest.php:105

And from what I can see in the code as a fourth parameter, it is passing a mock of an LoggerInterface

Could you help me?

Thank you.

@ajcerezo ajcerezo force-pushed the ajcerezo:feature/add-cache-couchbase-bucket-adapter branch from 361def8 to 5762c8e Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.