[Mime] fixed wrong mimetype #32986
Merged
[Mime] fixed wrong mimetype #32986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The list there is automatically computed so we cannot patch it like that. |
|
So I better revert my changes and catch this error in the |
|
yes please |
|
Wouldn't it be better to change the code that generates the list to exclude non valid values? |
|
And where are these lists generated? Should this code be changed or should a check be added on the |
|
|
|
I removed the od* file extensions from the generator script. |
fabpot
approved these changes
Aug 7, 2019
fabpot
force-pushed
the
datapart-frompath
branch
from
84816c4
to
e1722c5
Compare
|
Thank you @rjwebdev. |
fabpot
added a commit
that referenced
this pull request
Aug 7, 2019
This PR was squashed before being merged into the 4.3 branch (closes #32986). Discussion ---------- [Mime] fixed wrong mimetype | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32816 | License | MIT When creating a datapart from an odt file (and some other extensions), the explode function for the picked mimetype gives a wrong result since there's no `application/` prefix for the first mimetype of this extension. In this PR, all mimetypes without a prefix are removed. Commits ------- e1722c5 [Mime] fixed wrong mimetype
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a datapart from an odt file (and some other extensions), the explode function for the picked mimetype gives a wrong result since there's no
application/prefix for the first mimetype of this extension.In this PR, all mimetypes without a prefix are removed.