[Cache] remove implicit dependency on symfony/filesystem #33922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-no-fs
branch
from
86212fe
to
85f27f2
Compare
nicolas-grekas
commented
Oct 9, 2019
| @@ -137,11 +129,6 @@ protected function doInvalidate(array $tagIds): bool | |||
| return true; | |||
There was a problem hiding this comment.
File representing cache tag where you append cache keys?
Could do that, but then:
- more work (with race) to clean up relationship when tags are removed from an item _(unless we continue to view that as eventually consistent)
- can it hit file limits if it only appends and never cares if cache key is already there?
- on invalidation probably need to rename like with redis to be able to iterate and clear without race possibilities
So can work, but might present its own set of challenges.
Would it be better than replacing symlinks with just simple files that contain the cache key as value?
There was a problem hiding this comment.
(continued in #33924 (comment))
stof
approved these changes
Oct 9, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 9, 2019
…nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [Cache] remove implicit dependency on symfony/filesystem | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - /cc @andrerom for review Commits ------- 85f27f2 [Cache] remove implicit dependency on symfony/filesystem
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @andrerom for review