[HttpClient] allow option "buffer" to be a stream resource #34051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 21, 2019
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
hc-buffer-fopen
branch
from
daee632 to
e873016
Compare
darielopper
approved these changes
Oct 21, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 22, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] skip tests implemented in 4.4 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Needed after #34051 and #34044 Commits ------- ae86ab1 [HttpClient] skip tests implemented in 4.4
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2019
…urce (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] allow option "buffer" to be a stream resource | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- e873016 [HttpClient] allow option "buffer" to be a stream resource
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.