[Translation] Fix FileDumper behavior #34797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
force-pushed
the
trans_dump
branch
2 times, most recently
from
953c7e2
to
1f4b077
Compare
fabpot
approved these changes
Dec 4, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Translation] Fix FileDumper behavior | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34713 | License | MIT | Doc PR | - Execute `bin/console translation:update --force en` command: ## Before See related issue for details #34713 ## After The default translation file name will depend on whether the intl (or polyfill) extension is installed or not. For exmaple: | Intl extension (or polyfill) installed | translation file created | | --- | --- | | no | messages.en.xlf | | yes | messages+intl-icu.en.xlf | However, if you are currently updating a single file, that file name will be used regardless of whether the Intl extension is installed, i.e. if you have this translation file: `messages.en.xlf`, new translation keys will be stored in it, even if you have installed the intl extension. Last, if both translation files (`messages.es.xlf` and `messages+intl-icu.en.xlf`) coexist in the same path, rare but possible, we will use the default filename guessed earlier to store all current messages and the another file will be emptied. Commits ------- 1c41ae7 Fixed translations file dumper behavior
nicolas-grekas
added a commit
that referenced
this pull request
Jan 21, 2020
…fix #34713 (yceruto) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Revert #34797 "Fixed translations file dumper behavior" and fix #34713 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35264 | License | MIT | Doc PR | - Revert #34797 See also #35328 It's very likely that the new way will be completely different from this one that is being reverted. That's why I'm reverting rather than fixing it. Commits ------- 9ca8720 Fixed #34713 Move new messages to intl domain when possible 56e79fe Revert "Fixed translations file dumper behavior"
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jan 21, 2020
…d fix #34713 (yceruto) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Revert #34797 "Fixed translations file dumper behavior" and fix #34713 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35264 | License | MIT | Doc PR | - Revert symfony/symfony#34797 See also symfony/symfony#35328 It's very likely that the new way will be completely different from this one that is being reverted. That's why I'm reverting rather than fixing it. Commits ------- 9ca872054b Fixed #34713 Move new messages to intl domain when possible 56e79fefa1 Revert "Fixed translations file dumper behavior"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute
bin/console translation:update --force encommand:Before
See related issue for details #34713
After
The default translation file name will depend on whether the intl (or polyfill) extension is installed or not.
For exmaple:
However, if you are currently updating a single file, that file name will be used regardless of whether the Intl extension is installed, i.e. if you have this translation file:
messages.en.xlf, new translation keys will be stored in it, even if you have installed the intl extension.Last, if both translation files (
messages.es.xlfandmessages+intl-icu.en.xlf) coexist in the same path, rare but possible, we will use the default filename guessed earlier to store all current messages and the another file will be emptied.