Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Add the ability to expect a deprecation inside a test #35192

Open
wants to merge 1 commit into
base: master
from

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Jan 3, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR todo

Replaces #25757

Proposed implementation uses a dedicated trait for a better DX. Using $this->expectDeprecation() feels natural.

Unfortunately it is not currently possible to test the cases that should produce errors or risky, so there are some things that are not testable here. I plan to propose another feature for the PhpUnitBridge to be able to test those kind of things. If it's accepted, we will then be able to strenghten the tests of this one.

@fancyweb

This comment has been minimized.

Copy link
Contributor Author

fancyweb commented Jan 3, 2020

fabbot failure must remain for 5.3 compat.

@fancyweb fancyweb force-pushed the fancyweb:phpunit-bridge-expect-deprecation-in-test branch from 3037bdc to c84e1c8 Jan 3, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Jan 4, 2020
@fancyweb fancyweb force-pushed the fancyweb:phpunit-bridge-expect-deprecation-in-test branch from c84e1c8 to 19e3d1f Jan 14, 2020
@fancyweb fancyweb force-pushed the fancyweb:phpunit-bridge-expect-deprecation-in-test branch from 19e3d1f to 4dd759e Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.