Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix HttpClientDataCollector when handling canceled responses #35672

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@thematchless
Copy link
Contributor

thematchless commented Feb 11, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

small addition to the already merged #35562

…nses
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 11, 2020

Thank you @thematchless.

nicolas-grekas added a commit that referenced this pull request Feb 11, 2020
…celed responses (thematchless)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix HttpClientDataCollector when handling canceled responses

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

small addition to the already merged #35562

Commits
-------

7088ef7 [HttpClient] fix HttpClientDataCollector when handling canceled responses
@nicolas-grekas nicolas-grekas merged commit 7088ef7 into symfony:4.4 Feb 11, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details
@thematchless thematchless deleted the thematchless:hc-canceled branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.