Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix CheckTypeDeclarationPass #36108

Merged
merged 1 commit into from Mar 18, 2020
Merged

[DI] Fix CheckTypeDeclarationPass #36108

merged 1 commit into from Mar 18, 2020

Conversation

@guillbdx
Copy link
Contributor

guillbdx commented Mar 17, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35863 and #35972
License MIT
Doc PR

Bug 1: The lint container threw an error if a class buit with a factory was declared as callable while this factory method returne a callabe (#35863)

Bug 2: Sodium Exception was not caught in the CheckTypeDeclarationsPass. We have extended the exception caught to \Exception, instead of EnvNotFoundException and RuntimeException only.

@guillbdx guillbdx changed the title Di fix check type declaration pass [DI] Fix CheckTypeeclarationPass Mar 17, 2020
@guillbdx guillbdx changed the title [DI] Fix CheckTypeeclarationPass [DI] Fix CheckTypeDeclarationPass Mar 17, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Mar 17, 2020
Copy link
Member

nicolas-grekas left a comment

Thanks.
The 'iterable' case looks similar, we should add 'iterable' === $class there also

@stloyd
stloyd approved these changes Mar 17, 2020
@fabpot
fabpot approved these changes Mar 18, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 18, 2020

Thank you @guillbdx.

@fabpot fabpot merged commit 7baec32 into symfony:4.4 Mar 18, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
This was referenced Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.