[Security/Core] fix escape for username in LdapBindAuthenticationProvider.php #36498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoccc
changed the title
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Apr 21, 2020
|
Thank you @stoccc. |
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that when we call
ldap_search()as definitely it will do the$this->ldap->query()call, the proper filter applied should beLdapInterface::ESCAPE_FILTERas documented inhttps://www.php.net/manual/en/function.ldap-escape.php while
LdapInterface::ESCAPE_DNshould be used fordnonlyThis simple change should fix, I'm sorry if I'm wrong.