Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call method_exists() with non-objects. #36938

Merged
merged 1 commit into from
May 24, 2020
Merged

Don't call method_exists() with non-objects. #36938

merged 1 commit into from
May 24, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

Followup to #36901.

@derrabus derrabus requested a review from sroze as a code owner May 24, 2020 10:15
@derrabus derrabus force-pushed the bugfix/strict-method-exists branch from 1153cd7 to 9efb442 Compare May 24, 2020 10:15
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 24, 2020
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 24, 2020 •
edited
Loading

For reference, we're suggesting to relax method_exists() in PHP 8 in https://bugs.php.net/79623
We can still do this change of course.

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 5233cb9 into symfony:5.1 May 24, 2020
@derrabus derrabus deleted the bugfix/strict-method-exists branch May 24, 2020 12:06
@fabpot fabpot mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot