Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Missing return in loadValuesForChoices method #37499

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[Form] Missing return in loadValuesForChoices method #37499

merged 1 commit into from
Jul 6, 2020

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jul 6, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@yceruto yceruto added this to the 5.1 milestone Jul 6, 2020
@yceruto yceruto requested a review from xabbuh as a code owner July 6, 2020 00:55
@yceruto yceruto mentioned this pull request Jul 6, 2020
Closed
@fabpot
Copy link
Member

fabpot commented Jul 6, 2020

Thank you @yceruto.

@fabpot fabpot merged commit 309b062 into symfony:5.1 Jul 6, 2020
@yceruto yceruto deleted the choice_loader_bug branch July 6, 2020 12:28
@fabpot fabpot mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yceruto @fabpot @carsonbot