[String] throw when Alpine is used and translit fails #37514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 7, 2020
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 5.0 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37213 |
| License | MIT |
| Doc PR | - |
glensc
reviewed
Jul 7, 2020
nicolas-grekas
force-pushed
the
string-iconv-translit
branch
from
8ffd037 to
98f5d50
Compare
stof
reviewed
Jul 8, 2020
| @@ -142,8 +142,10 @@ public function ascii(array $rules = []): self | |||
| } elseif (ICONV_IMPL === 'glibc') { | |||
| $s = iconv('UTF-8', 'ASCII//TRANSLIT', $s); | |||
| } else { | |||
| $s = preg_replace_callback('/[^\x00-\x7F]/u', static function ($c) { | |||
| $c = iconv('UTF-8', 'ASCII//IGNORE//TRANSLIT', $c[0]); | |||
| $s = @preg_replace_callback('/[^\x00-\x7F]/u', static function ($c) { | |||
There was a problem hiding this comment.
why silencing the whole preg_replace_callback call ? shouldn't we silence the iconv call only ?
There was a problem hiding this comment.
This makes toggling the error reporting mode only once while doing it in the callback toggles once per match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.