Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lock] Fix wrong interface for MongoDbStore #38134

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[Lock] Fix wrong interface for MongoDbStore #38134

merged 1 commit into from
Sep 10, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Sep 9, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

The MongoDbStore is not a BlockingStore because does not "really" implements the method waitAndSave.

This PR changes the interface of MongoDbStore and remove the dummy implementation of waitAndSave.

@jderusse jderusse changed the base branch from master to 5.1 September 9, 2020 22:11
@jderusse jderusse force-pushed the lock-blocking-mongo branch 2 times, most recently from b4a229d to 324e149 Compare September 9, 2020 22:45
fabpot
fabpot approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a slight BC break, so I would merge it in master instead.

@xabbuh xabbuh added the Lock label Sep 10, 2020
@jderusse jderusse changed the base branch from 5.1 to master September 10, 2020 08:36
@nicolas-grekas nicolas-grekas changed the title Fix wrong interface for MongoDbStore [Lock] Fix wrong interface for MongoDbStore Sep 10, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 10, 2020
@nicolas-grekas
Copy link
Member

Worth a note in the UPGRADE file + CHANGELOG of the component, isn't it?

@jderusse jderusse force-pushed the lock-blocking-mongo branch 2 times, most recently from 6e93eac to be2febb Compare September 10, 2020 09:33
@jderusse
Copy link
Member Author

Entry in changelog and upgrade added.

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 474e877 into symfony:master Sep 10, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 10, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
@jderusse jderusse deleted the lock-blocking-mongo branch October 15, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Lock Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jderusse @nicolas-grekas @fabpot @xabbuh @carsonbot