[HttpClient] fail properly when the server replies with HTTP/0.9 #38148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Sep 10, 2020
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37923 |
| License | MIT |
| Doc PR | - |
|
what about other client implementations ? |
|
and this seems to break the http push tests and many tests on Travis |
fabpot
requested changes
Sep 11, 2020
nicolas-grekas
force-pushed
the
hc-no-h09
branch
from
7b03157 to
1f28563
Compare
they already fail properly, only curl knows about HTTP/0.9
fixed hopefuly |
nicolas-grekas
force-pushed
the
hc-no-h09
branch
from
1f28563 to
f7ed6bf
Compare
nicolas-grekas
force-pushed
the
hc-no-h09
branch
from
f7ed6bf to
96759af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.