Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] added missing Albanian translations #38835

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

abame
Copy link
Contributor

@abame abame commented Oct 26, 2020

[Translation] added missing Albanian translations for the following components:

  1. [Forms]
  2. [Security][Core]
  3. [Validator]
Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38722
License MIT

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you

I used Google translate to try to verify these. My comments below might be wrong, but could you check?

</trans-unit>
<trans-unit id="113">
<source>Please select a valid locale.</source>
<target>Ju lutemi zgjidhni një lokale të vlefshme.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check if this is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. Just as an explanation, from Google Translate the word lokal means a place where you can have a coffee and the correct word is lokale in this context

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey. Cool!

@abame
Copy link
Contributor Author

abame commented Oct 26, 2020

I don't understand why the typo check is failing when that's the correct word in Albanian.

@Nyholm
Copy link
Member

Nyholm commented Oct 26, 2020

It is failing because Fabbot only speaks English. We can ignore that. =)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job.

Im super happy with this now
👍

@nicolas-grekas
Copy link
Member

Thank you @abame.

@nicolas-grekas nicolas-grekas merged commit f366593 into symfony:3.4 Oct 27, 2020
@abame abame deleted the missing_albanian_translations branch March 14, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants