[Console] Register signal handling only for commands implemeting SignalableCommandInterface #38845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alableCommandInterface Actually, it does not make sens to listen all signals for all commands. This commit also add more test for this part of code.
lyrixx
force-pushed
the
console-signal
branch
from
0b13dcc to
37b1fae
Compare
|
Fabbot failures are not related to my diff. Should I fix it? |
|
They are false positives to me. |
nicolas-grekas
approved these changes
Oct 27, 2020
|
Thank you @lyrixx. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, it does not make sens to listen all signals for all commands.
This commit also add more tests for this part of code.